Skip to content

Fix Precision compute for all zero predictions#2017

Merged
vfdev-5 merged 6 commits intopytorch:masterfrom
tarasio-mirror:prec-update-fix
May 31, 2021
Merged

Fix Precision compute for all zero predictions#2017
vfdev-5 merged 6 commits intopytorch:masterfrom
tarasio-mirror:prec-update-fix

Conversation

@tarasio-mirror
Copy link
Copy Markdown
Contributor

Fixes #2007

Description:

  • Introduced _updated flag for update checks
  • Recall is adjusted
  • Precision and Recall Tests are updated

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label May 31, 2021
@tarasio-mirror tarasio-mirror changed the title Prec update fix Fix Precision compute for all zero predictions May 31, 2021
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented May 31, 2021

@trsvchn thanks for the PR, it looks good ! Can you please add the issue case with all zeros predictions ?

@tarasio-mirror
Copy link
Copy Markdown
Contributor Author

Oh, right! sure!

@vfdev-5 vfdev-5 enabled auto-merge (squash) May 31, 2021 15:33
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trsvchn

@vfdev-5 vfdev-5 merged commit be2bff8 into pytorch:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: metrics Metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Precision raises an NonComputableError for all zeros model predictions

2 participants