move EpochOutputStore out of contrib keeping BC#1982
Merged
vfdev-5 merged 3 commits intopytorch:masterfrom May 1, 2021
radekosmulski:move_eos
Merged
move EpochOutputStore out of contrib keeping BC#1982vfdev-5 merged 3 commits intopytorch:masterfrom radekosmulski:move_eos
vfdev-5 merged 3 commits intopytorch:masterfrom
radekosmulski:move_eos
Conversation
Collaborator
|
@radekosmulski thanks a lot ! I think there could be something to do with docs as failing job here is real : Could you also please put "Fixes #1939" instead of "Implements" to close the issue automatically once the PR is merged. Thanks |
Collaborator
|
@radekosmulski can we improve the docstring example as well : eos = EpochOutputStore()
trainer = create_supervised_trainer(model, optimizer, loss)
train_evaluator = create_supervised_evaluator(model, metrics)
eos.attach(train_evaluator, 'output')
@trainer.on(Events.EPOCH_COMPLETED)
def log_training_results(engine):
train_evaluator.run(train_loader)
output = train_evaluator.output
# output = [(y_pred0, y0), (y_pred1, y1), ...]
# do something with output, e.g., plottingIt would be also very helpful to add I also think we should fix typing hint here: - self.data = [] # type: List[Union[int, Tuple[int, int]]]
+ self.data = [] # type: List[Any] |
vfdev-5
approved these changes
May 1, 2021
Collaborator
vfdev-5
left a comment
There was a problem hiding this comment.
@radekosmulski thanks a lot for the PR ! LGTM!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1939
Description: Moves
EpochOutputStoreout ofcontribkeeping BC.Check list: