Skip to content

Added full read permissions to saved file (1876)#1880

Merged
vfdev-5 merged 3 commits intopytorch:masterfrom
vfdev-5:issue-1876-fix-file-mode
Mar 27, 2021
Merged

Added full read permissions to saved file (1876)#1880
vfdev-5 merged 3 commits intopytorch:masterfrom
vfdev-5:issue-1876-fix-file-mode

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Mar 26, 2021

Fixes #1876

Description:

  • Added full read rights to saved file when atomic=True

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Added full read rights to saved file when atomic=True
Copy link
Copy Markdown
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good !

@sdesrozis
Copy link
Copy Markdown
Contributor

It misses mkl libs for tpu...

@vfdev-5
Copy link
Copy Markdown
Collaborator Author

vfdev-5 commented Mar 26, 2021

I think it is the new pytorch release that fails our ci :)

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 27, 2021 00:11
@vfdev-5 vfdev-5 merged commit 6bfb1f5 into pytorch:master Mar 27, 2021
@vfdev-5 vfdev-5 deleted the issue-1876-fix-file-mode branch March 28, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: handlers Core Handlers module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkpoint handler save files with wrong permissions

2 participants