Skip to content

#1615 : add check_opencv function in 'build_all.sh' for 'vision' . #1643

Merged
vfdev-5 merged 3 commits intomasterfrom
docker-cv2-fix
Feb 17, 2021
Merged

#1615 : add check_opencv function in 'build_all.sh' for 'vision' . #1643
vfdev-5 merged 3 commits intomasterfrom
docker-cv2-fix

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Feb 15, 2021 •
edited
Loading

Fixes #1615

Original PR: #1628

Switch to 'opencv-python-headless'. (#1628)

Co-authored-by: vfdev [email protected]

Fixes #{issue number}

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@fco-dv @vfdev-5
#1615 : add check_opencv function in 'build_all.sh' for 'vision' . Sw…
5f3e573 
…itch to 'opencv-python-headless'. (#1628)

Co-authored-by: vfdev <[email protected]>
@vfdev-5
Copy link
Copy Markdown
Collaborator Author

vfdev-5 commented Feb 15, 2021 •
edited
Loading

@fco-dv probably, the check as you did are not working:

Successfully tagged pytorchignite/hvd-vision:latest
./hvd/build_all.sh: 69: [[: not found
./hvd/build_all.sh: 69: hvd-vision: not found

https://app.circleci.com/pipelines/github/pytorch/ignite/1358/workflows/d21bbba3-d96b-443d-b365-10c592dc85b7/jobs/3864/parallel-runs/0/steps/0-102

As executed as sh vs bash, maybe.

@fco-dv
Copy link
Copy Markdown
Contributor

fco-dv commented Feb 15, 2021 •
edited
Loading

@vfdev-5 was running the script with bash hvd/build_all.sh on my local machine, seems like this fix should work with sh ./hvd/build_all.sh :

    if [ ${image_name} = "hvd-vision" ] || [ ${image_name} = "hvd-apex-vision" ]; then
        check_opencv "pytorchignite/${image_name}:latest"
    fi

@vfdev-5
Copy link
Copy Markdown
Collaborator Author

vfdev-5 commented Feb 15, 2021 •
edited
Loading

@fco-dv I think it would be better to run all those checks in a python script as suggested #1644.

In the current PR, msdp fix for vision image is still missing right ?

@fco-dv
Copy link
Copy Markdown
Contributor

fco-dv commented Feb 15, 2021

yes that's right for msdp

@vfdev-5
Copy link
Copy Markdown
Collaborator Author

vfdev-5 commented Feb 15, 2021

@sdesrozis please do not update this PR as it trigger new docker images build :) to much computations for nothing

@sdesrozis
Copy link
Copy Markdown
Contributor

sdesrozis commented Feb 15, 2021

Sorry 😢

@vfdev-5 vfdev-5 merged commit e81767b into master Feb 17, 2021
@vfdev-5 vfdev-5 deleted the docker-cv2-fix branch February 17, 2021 20:33
vfdev-5 added a commit that referenced this pull request Mar 3, 2021
@vfdev-5 @fco-dv @sdesrozis
#1615 : add check_opencv function in 'build_all.sh' for 'vision' . (#…
ee2fc42 
…1643)

* #1615 : add check_opencv function in 'build_all.sh' for 'vision' . Switch to 'opencv-python-headless'. (#1628)

Co-authored-by: vfdev <[email protected]>

* fix script bash -> sh

Co-authored-by: François COKELAER <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportError: libGL.so.1: cannot open shared object file

3 participants

@vfdev-5 @fco-dv @sdesrozis