Skip to content

#1615 : add check_opencv function in 'build_all.sh' for 'vision' . Sw…#1628

Merged
vfdev-5 merged 2 commits intopytorch:docker-cv2-fixfrom
fco-dv:docker-vision-import
Feb 15, 2021
Merged

#1615 : add check_opencv function in 'build_all.sh' for 'vision' . Sw…#1628
vfdev-5 merged 2 commits intopytorch:docker-cv2-fixfrom
fco-dv:docker-vision-import

Conversation

@fco-dv
Copy link
Copy Markdown
Contributor

@fco-dv fco-dv commented Feb 10, 2021

Fixes #1615
Description:
add check_opencv function in 'build_all.sh' for 'vision' . Switch to 'opencv-python-headless'. add libgl1-mesa-glx for pytorch-*-devel` based images.

Check list:
Images builds OK {main, hvd} PTH_VERSION=1.7.1-cuda11.0-cudnn8, HVD_VERSION=v0.21.2, ignite=0.4.3

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 10, 2021

@fco-dv Thanks for the PR !

Maybe, we could add a test python script into tests or docker to check cv2 import and also version correctness of torch and ignite ?

@fco-dv
Copy link
Copy Markdown
Contributor Author

fco-dv commented Feb 10, 2021

yes @vfdev-5 seems a good way to check correctness, let me try this

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 15, 2021

@fco-dv can we advance on this PR to solve it more quickly as all vision docker images are broken now.

@vfdev-5 vfdev-5 changed the base branch from master to docker-cv2-fix February 15, 2021 11:17
@vfdev-5 vfdev-5 merged commit 5f3e573 into pytorch:docker-cv2-fix Feb 15, 2021
@fco-dv fco-dv deleted the docker-vision-import branch February 15, 2021 11:27
vfdev-5 added a commit that referenced this pull request Feb 17, 2021
…1643)

* #1615 : add check_opencv function in 'build_all.sh' for 'vision' . Switch to 'opencv-python-headless'. (#1628)

Co-authored-by: vfdev <[email protected]>

* fix script bash -> sh

Co-authored-by: François COKELAER <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
@vfdev-5 vfdev-5 mentioned this pull request Mar 3, 2021
vfdev-5 added a commit that referenced this pull request Mar 3, 2021
…1643)

* #1615 : add check_opencv function in 'build_all.sh' for 'vision' . Switch to 'opencv-python-headless'. (#1628)

Co-authored-by: vfdev <[email protected]>

* fix script bash -> sh

Co-authored-by: François COKELAER <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: libGL.so.1: cannot open shared object file

2 participants