Use standard stream for loggers#1601
Merged
vfdev-5 merged 12 commits intopytorch:masterfrom Feb 2, 2021
Merged
Conversation
…to logger_stream Conflicts: ignite/distributed/utils.py
vfdev-5
approved these changes
Feb 1, 2021
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Looks good, thanks @sdesrozis !
Collaborator
|
@sdesrozis please, add a mention here about added arg, like here : https://github.com/pytorch/ignite/pull/1600/files |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
By default, loggers stream on
sys.stderr. This PR allows to define the stream and the default stream is nowsys.stdout. This is useful whenigniteis used with workload manager likeslurm.EDIT : replace default
sys.stderrbystd.stdoutdoes not work in tests (check_config idist). It could be an issue capsys / pytestEDIT 2 : It seems that
https://pypi.org/project/pytest-catchlog/provides fixture that helps to catch stream from logs.Check list: