Remove unnecessary test prints#1282
Closed
nzare wants to merge 8 commits intopytorch:masterfrom
nzare:remove-unnecessary-test-prints
Closed
Remove unnecessary test prints#1282nzare wants to merge 8 commits intopytorch:masterfrom nzare:remove-unnecessary-test-prints
nzare wants to merge 8 commits intopytorch:masterfrom
nzare:remove-unnecessary-test-prints
Conversation
vfdev-5
reviewed
Sep 12, 2020
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I left a comment in the code.
Could you please also remove :
- https://github.com/pytorch/ignite/blob/master/tests/ignite/engine/test_engine.py#L620
- https://github.com/pytorch/ignite/blob/master/tests/ignite/distributed/comp_models/test_xla.py#L189-L191
- https://github.com/pytorch/ignite/blob/master/tests/ignite/metrics/test_top_k_categorical_accuracy.py#L71
Contributor
Author
|
Can you please review it now ? |
Collaborator
|
@nzare could you please fix flake8 error : https://travis-ci.org/github/pytorch/ignite/jobs/726552697#L242 |
Contributor
Author
|
I checked flake8 error I tried fixing with autopep and tried changing spacing etc but none of them seems to work |
Collaborator
|
you can try to run `black .` on the codebase. For details, please read
CONTRIBUTING.md
…On Sat, Sep 12, 2020, 18:26 Nidhi Zare ***@***.***> wrote:
I checked flake8 error
./tests/ignite/metrics/test_top_k_categorical_accuracy.py:70:1: W293 blank
line contains whitespace
I tried fixing with autopep and tried changing spacing etc but none of
them seems to work
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1282 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASYOH4WTYMRLSLXXWGSXPTSFOOLZANCNFSM4RJB3O6A>
.
|
Collaborator
Merged
Contributor
Author
|
Merged master and opened a new pull request as it was facing some merging issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1240
Remove useless prints from tests