Skip to content

Fixes #1110#1112

Merged
vfdev-5 merged 3 commits intopytorch:masterfrom
vfdev-5:issue-1110
Jun 7, 2020
Merged

Fixes #1110#1112
vfdev-5 merged 3 commits intopytorch:masterfrom
vfdev-5:issue-1110

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Jun 7, 2020

Fixes #1110

Description:

  • Comp models are defined if has corresponding support, otherwise no class definition.
  • Adapted code and [wip] some tests for windows (waiting until CI is available)

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Fixes pytorch#1110
f2f633a 
[WIP] Adapted code and tests for windows
@vfdev-5 vfdev-5 mentioned this pull request Jun 7, 2020
Merged
3 tasks
@vfdev-5 vfdev-5 requested review from erip and sdesrozis June 7, 2020 14:14
erip
erip approved these changes Jun 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@erip erip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@vfdev-5 vfdev-5 merged commit 479659a into pytorch:master Jun 7, 2020
@vfdev-5 vfdev-5 deleted the issue-1110 branch June 7, 2020 15:04
sdesrozis
sdesrozis approved these changes Jun 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@erip erip erip approved these changes

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0.4.0-pre import ignite broken on Windows machine with cpu-only

3 participants

@vfdev-5 @erip @sdesrozis