Fixed incorrect log position. (#1098)#1099
Merged
vfdev-5 merged 4 commits intopytorch:masterfrom Jun 4, 2020
Merged
Conversation
vfdev-5
reviewed
Jun 3, 2020
ignite/engine/engine.py
Outdated
| self._fire_event(Events.TERMINATE) | ||
| break | ||
| self._fire_event(Events.EPOCH_COMPLETED) | ||
| self.logger.info("Epoch[%s] Complete. Time taken: %02d:%02d:%02d", self.state.epoch, hours, mins, secs) |
Collaborator
There was a problem hiding this comment.
Maybe, we also need to call it after self._fire_event(Events.TERMINATE) with message "Epoch[%s] Terminated. ..."
Collaborator
|
@Yevgnen thanks a lot for the PR ! |
vfdev-5
changed the title
Contributor
Author
|
@vfdev-5 Following the contributing guide, I try to re-run the tests, but got |
Collaborator
|
Yes, this should be a forgotten to mention :) Thanks for pointing out ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1098
Description:
Fire all events before logging time usages to prevent incorrect log position.
Check list: