-
-
Notifications
You must be signed in to change notification settings - Fork 692
Fix a few bugs in engine interrupt/resume feature #2689
Copy link
Copy link
Closed
Description
🐛 Bug description
- A typo in docstrings. 0.4.10 or 0.5.0?
-
_run_once_on_dataset_as_genis restarted (because it is called) whenever we get into_internal_run_as_gen -
Some statements before_run_once_on_dataset_as_genshould be skipped on resume and some other after that should be skipped on interrupt -
Once running after a terminated state,_run_once_on_dataset_as_genshould be set to None before entering_internal_run. -
If engine was interrupted in the middle of the last epoch,is_doneincorrectly returns True on resume thus preventing it. -
_run_once_on_dataset_as_genyields the state on interrupt, not the time, so this shoud be changed. - Since
_run_once_on_dataset_as_genhas both return value and yield value with different types, its annotation could be updated to reflect this e.g. becomeGenerator[State, None, float]
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels