Skip to content

Improve docker build scripts #1644

@vfdev-5

Description

@vfdev-5

🚀 Feature

Currently, we can build and publish dockers using Circle CI and it works more or less well, however, PR's modifying Dockerfile can not build docker images to ensure PR correctness (related to the way how the PR is checkout on Circle CI).

The idea is

  • refactor all build_all.sh scripts (docker/main/build_all.sh, docker/hvd/build_all.sh and docker/msdp/build_all.sh) into a single shell script that could build a single docker image.
  • use github actions to build only on PR a single docker image and introduce a single yml file for that (to see what can be done).
    • publishing will use existing scripts
  • add a test inside docker folder as a python script to check docker image versions for : torch, ignite ; can import cv2 ; maybe something else.

To Do list:

  • refactor build_all.sh into build.sh
  • run docker image build for PR on GA
  • run tests on built image. Tests
    • For all images
      • can import torch and its version == required one
      • can import ignite and its version == required one
    • for all -vision images
      • can import opencv without driver issue
    • for all horovod images
      • can import horovod and its version == required one
    • for all msdp images
      • can import deepspeed and its version == required one

cc @fco-dv

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions