Merged
Conversation
meta-cla
bot
added
the
CLA Signed
oulgen
requested changes
Nov 17, 2025
|
|
||
| - repo: https://github.com/RobertCraigie/pyright-python | ||
| rev: v1.1.407 | ||
| - repo: https://github.com/facebook/pyrefly-pre-commit |
Contributor
There was a problem hiding this comment.
can we use the pyrefly with the version in the config? i think @lolpack added something?
Contributor
Author
There was a problem hiding this comment.
I tried switching to the second option here that's supposed to let you specify the version, but I couldn't get it to work. Pyrefly starts producing a lot of import errors (on torch, triton, etc.) that suggest it's no longer able to find dependencies.
Contributor
Author
There was a problem hiding this comment.
I opened an issue against pyrefly-pre-commit: facebook/pyrefly-pre-commit#7.
Update references to pyright and pyre, respectively.
oulgen
approved these changes
Nov 17, 2025
Contributor
Author
|
Woohoo! @oulgen thanks for the speedy review |
rchen152
added a commit
to rchen152/helion
that referenced
this pull request
Dec 3, 2025
This is a follow-up to a reviewer request in pytorch#1143 to use an isolated environment for the pyrefly pre-commit hook. Unfortunately, I don't think that's practical to do (see facebook/pyrefly-pre-commit#7 (comment)). But in the process of looking into this, I ended up giving the hook a better name and versioning system, which this PR updates helion's pre-commit config to use.
This was referenced Dec 3, 2025
umechand-amd
pushed a commit
to umechand-amd/helion
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the type checker for helion from pyright to pyrefly. Benefits of switching:
# pyright: ignoredirectives; only 340# pyrefly: ignoredirectives are needed.The bulk of this PR is a mechanical removal of pyright suppressions and addition of pyrefly suppressions. The interesting changes are:
typing.castcalls that are no longer needed.