Skip to content

Commit f7abaf0

Browse files
nit: match the surrounding tensor naming in the select_scatter test
1 parent 000ce9c commit f7abaf0

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎kernels/test/op_select_scatter_test.cpp‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -669,13 +669,14 @@ TEST_F(OpSelectScatterOutTest, DynamicShapeUnbound) {
669669
TEST_F(OpSelectScatterOutTest, NonDefaultDimOrderDies) {
670670
TensorFactory<ScalarType::Float> tf;
671671

672-
// src is one rank below in, so at rank 4 the same dim order check above
672+
// src is one rank below x, so at rank 4 the same dim order check above
673673
// rejects first. Only rank 5 reaches the default dim order check, because
674674
// is_channels_last_dim_order accepts both 4 and 5 dims.
675-
Tensor in = tf.make_with_dimorder(
675+
Tensor x = tf.make_with_dimorder(
676676
{2, 2, 2, 2, 2}, std::vector<float>(32, 1), {0, 2, 3, 4, 1});
677677
Tensor src = tf.make_with_dimorder(
678678
{2, 2, 2, 2}, std::vector<float>(16, 2), {0, 2, 3, 1});
679+
679680
Tensor out = tf.make_with_dimorder(
680681
{2, 2, 2, 2, 2}, std::vector<float>(32), {0, 2, 3, 4, 1});
681682

@@ -684,5 +685,5 @@ TEST_F(OpSelectScatterOutTest, NonDefaultDimOrderDies) {
684685
"ATen kernel can handle non-default dim order");
685686

686687
ET_EXPECT_KERNEL_FAILURE(
687-
context_, op_select_scatter_out(in, src, /*dim=*/0, /*index=*/0, out));
688+
context_, op_select_scatter_out(x, src, /*dim=*/0, /*index=*/0, out));
688689
}

0 commit comments

Comments
 (0)