You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 21cbfd6
Browse filesBrowse the repository at this point in the historyBrowse files
Summary:
bypass-github-export-checks
Pull Request resolved: #2404
In #2271, we already added
- IntList
- DoubleList
- BoolList
- ValueList
to the schema and the runtime's Value class. Their serialization was incomplete missing two components:
1. Receiving a list in `torch.fx.Node.args`.
2. Receiving a non-tensor in `torch.fx.Node`.
This change completes #1.
Also, this change fixes a bug where values type `bool` matches both types `bool` and `int` and hence were being added twice.
If our type support grows more complex, we can consider using our own types similar to the core Executorch runtime: https://github.com/pytorch/executorch/blob/689796499024fc4a133318d707f4c10db73da967/exir/emit/_emitter.py#L158-L166
ghstack-source-id: 218539049
exported-using-ghexport
Reviewed By: SS-JIA
Differential Revision: D54708353
fbshipit-source-id: 8641647b515e201ea63db67115c01c1532ad6566
0 commit comments