Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Update PyTorch-CUDA for CUDA 12.4.1 Bump #1947

Merged
atalman merged 1 commit into from
Aug 20, 2024
Merged

Update PyTorch-CUDA for CUDA 12.4.1 Bump #1947

atalman merged 1 commit into from
Aug 20, 2024

Conversation

@nWEIdia
Copy link
Contributor

@nWEIdia nWEIdia commented Jul 31, 2024

Update constraints to use cuda 12.4.1 as [ and cuda 12.5.0 as )
CUDA 12.4.1 page: https://docs.nvidia.com/cuda/archive/12.4.1/cuda-toolkit-release-notes/index.html
CUDA 12.5.0 page: https://docs.nvidia.com/cuda/archive/12.5.0/cuda-toolkit-release-notes/index.html

Similar to: #1792

cc @atalman @malfet @ptrblck @eqy @tinglvv

@nWEIdia nWEIdia mentioned this pull request Aug 1, 2024
Closed
malfet
malfet approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but wouldn't that create a problem when one tries to install pytorch-2.4.0 using this new pytorch-cuda definition?

@nWEIdia
Copy link
Contributor Author

nWEIdia commented Aug 1, 2024

Maybe. there was a build number change to distinguish the pytorch-cuda at 2.4.0 release time vs. the new pytorch-cuda.
But I guess there is no automatic way to let 2.4.0 pick up pytorch-cuda v6 ?
This PR is v7.

@nWEIdia
Copy link
Contributor Author

nWEIdia commented Aug 1, 2024

PyTorch-CUDA is like packaging index. The 2.4.0 binary's dependency should have already been hard-coded, therefore, it would know which cuda dependency conda package to pull?
Agree it would be best to test it out first in a test channel.

@nWEIdia
Copy link
Contributor Author

nWEIdia commented Aug 6, 2024

It looks like indeed the CUDA 12.4.1 anaconda pytorch-cuda package would be picked up, if this PR gets merged.
Tested with anaconda/nweidia pytorch-cuda where both v6 and v7 were present and used the following anaconda command:
conda install pytorch pytorch-cuda=12.4 -c nweidia -c pytorch -c nvidia

@nWEIdia
Copy link
Contributor Author

nWEIdia commented Aug 6, 2024

What if we just upload the pytorch-cuda 12.4.1 packages to pytorch-nightly channel?
At next release, if cuda is updated to 12.4.1 too, we can then upload the packages to pytorch channel? Would this avoid the problem of "one tries to install pytorch-2.4.0 using this new pytorch-cuda definition" ?

cc @malfet @atalman @ptrblck

@atalman atalman merged commit 44d14c4 into pytorch:main Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nWEIdia @malfet @atalman @facebook-github-bot