Skip to content

Move linux unit test CI job tools to dedicated directory#605

Closed
mthrok wants to merge 1 commit intopytorch:masterfrom
mthrok:move-linux-unittest-cci
Closed

Move linux unit test CI job tools to dedicated directory#605
mthrok wants to merge 1 commit intopytorch:masterfrom
mthrok:move-linux-unittest-cci

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented May 3, 2020

No description provided.

@mthrok mthrok mentioned this pull request May 3, 2020
Merged
@mthrok mthrok requested a review from peterjc123 May 3, 2020 16:07
@codecov
Copy link

codecov bot commented May 3, 2020 •
edited
Loading

Codecov Report

Merging #605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          21       21           
  Lines        2254     2254           
=======================================
  Hits         2002     2002           
  Misses        252      252

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be18755...bca45ed. Read the comment docs.

@mthrok mthrok force-pushed the move-linux-unittest-cci branch from 66e4768 to bca45ed Compare May 3, 2020 16:10
peterjc123
peterjc123 approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. lgtm

@mthrok
Copy link
Contributor Author

mthrok commented May 3, 2020

@peterjc123 I need you to click "Submit Review" with Approve selected.

Screen Shot 2020-05-03 at 12 23 59

peterjc123
peterjc123 approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. lgtm

@peterjc123
Copy link
Contributor

peterjc123 commented May 3, 2020 •
edited
Loading

@mthrok Already done that. Is it because I don't have write access here?
Reference: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/approving-a-pull-request-with-required-reviews

@mthrok
Copy link
Contributor Author

mthrok commented May 3, 2020

@peterjc123
Oh I see. Sorry about that. Write access could be it but since I don't have admin access, I cannot add you as collaborator.
I guess you can cherry-pick my commits and add them to your original PR.

@mthrok mthrok closed this May 3, 2020
@vincentqb vincentqb reopened this May 3, 2020
vincentqb
vincentqb reviewed May 3, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why .circleci/unittest/docker/scripts/copy_kaldi_executables.sh → .circleci/unittest/linux/docker/scripts/copy_kaldi_executables.sh changed, but otherwise LGTM

vincentqb
vincentqb approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've re-opened the PR in case you would still like to merge this @mthrok or feel free to close it again

@peterjc123
Copy link
Contributor

peterjc123 commented May 4, 2020

Well, I cherry-picked this PR in mine. So I guess this one is not needed anymore.

@vincentqb
Copy link
Contributor

vincentqb commented May 4, 2020

Closed by #604

@vincentqb vincentqb closed this May 4, 2020
@mthrok mthrok deleted the move-linux-unittest-cci branch May 4, 2020 15:42
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Merge pull request pytorch#605 from mickypaganini/master
ad3493b 
Add pruning tutorial. Will create another PR to add it into the ToC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vincentqb vincentqb vincentqb approved these changes

@peterjc123 peterjc123 peterjc123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mthrok @peterjc123 @vincentqb