Enable unittest jobs for windows by peterjc123 · Pull Request #604 · pytorch/audio

peterjc123 · 2020-05-03T06:10:24Z

No description provided.

This reverts commit 8c15f66.

peterjc123 · 2020-05-03T14:41:04Z

.circleci/unittest/scripts/environment.yml

+    - kaldi-io #[win]
+    - PySoundFile #[win]
+    - librosa #[win]
+    - future #[win]


Well, I don't know exactly why this line is needed. But without it, an error will be thrown. Maybe it's an intermittent error at the CircleCI side.

Processing dependencies for torchaudio==0.6.0a0+b7648ac Searching for future Reading https://pypi.org/simple/future/ Downloading https://files.pythonhosted.org/packages/45/0b/38b06fd9b92dc2b68d58b75f900e97884c45bedd2ff83203d933cf5851c9/future-0.18.2.tar.gz#sha256=b1bead90b70cf6ec3f0710ae53a525360fa360d306a86583adc6bf83a4db537d error: Download error for https://files.pythonhosted.org/packages/45/0b/38b06fd9b92dc2b68d58b75f900e97884c45bedd2ff83203d933cf5851c9/future-0.18.2.tar.gz#sha256=b1bead90b70cf6ec3f0710ae53a525360fa360d306a86583adc6bf83a4db537d: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)

Thanks for noting this

vincentqb · 2020-05-03T15:17:36Z

Great! Let me know when this is ready for review :)

The plan will be to merge #604 and close #493, right?

mthrok · 2020-05-03T15:23:24Z

@peterjc123 Could we completely separate windows and linux unites scripts?
It appears to me that mixing them makes it harder to maintain.

I can move the current scripts from .circleci/unittest/scripts to .cicleci/unittest/scripts/linux. And windows specific files should go to .circleci/unittest/scripts/windows.

peterjc123 · 2020-05-03T15:41:28Z

@mthrok okay, I'll make the change if you move the existing script to that place.

peterjc123 · 2020-05-03T15:44:30Z

Great! Let me know when this is ready for review :)

The plan will be to merge #604 and close #493, right?

Yes, and It's ready for review but I'll consider @mthrok 's suggestion.

mthrok · 2020-05-03T15:53:34Z

The unit test scripts for linux are designed to work together with the underlying Docker image. This new Windows unit test does not follow the same structure, so it's better to separate Windows scripts and linux scripts for a long term maintainability.

mthrok · 2020-05-03T15:53:54Z

I'll do it a.s.a.p

mthrok · 2020-05-03T16:07:41Z

@peterjc123 #605 I moved all the linux unit test tools to .circleci/unittest/linux. (slight change from what originally suggested) Can you approve? then I can merge it. Also you can put all the necessary scripts under .circleci/unittest/windows.

peterjc123 · 2020-05-03T16:20:22Z

@mthrok approved and will do that.

vincentqb · 2020-05-03T23:13:13Z

Yes, and It's ready for review but I'll consider @mthrok 's suggestion.

sounds good!

nit: the PR is still marked both as draft and [WIP] :)

codecov · 2020-05-04T03:40:18Z

Codecov Report

Merging #604 into master will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   88.81%   88.99%   +0.17%     
==========================================
  Files          21       21              
  Lines        2254     2254              
==========================================
+ Hits         2002     2006       +4     
+ Misses        252      248       -4

Impacted Files	Coverage Δ
torchaudio/datasets/utils.py	`50.00% <0.00%> (+1.13%)`	⬆️
torchaudio/_backend.py	`88.88% <0.00%> (+5.55%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be18755...380de18. Read the comment docs.

peterjc123 · 2020-05-04T04:15:49Z

@vincentqb Marked as ready in both ways.

vincentqb

Since windows with python 3.6 and 3.7 pass, I assume 3.8 is flaky. I'll go ahead approve and merge. If this persists, we'll disable 3.8.

LGTM, thanks!

vincentqb · 2020-05-05T01:50:40Z

@peterjc123 -- do you want to also enable nightlies for windows?

peterjc123 · 2020-05-05T03:13:33Z

@vincentqb Will do that later.

Update index.rst - Adds torchscript to left nav

peterjc123 and others added 2 commits May 3, 2020 13:16

Turn on tests when building through conda-build

bec8010

skip one failling test on windows.

bc321b3

peterjc123 force-pushed the unittest_windows branch 3 times, most recently from 26ee217 to 4a200dd Compare May 3, 2020 08:04

peterjc123 mentioned this pull request May 3, 2020

Turn on tests when building through conda-build #493

Closed

peterjc123 force-pushed the unittest_windows branch 2 times, most recently from 2aa6eb8 to dcaf8cb Compare May 3, 2020 08:07

peterjc123 added 2 commits May 3, 2020 16:17

Switch to unittest

a47f7d4

Fix conda env activation

b0594a5

peterjc123 force-pushed the unittest_windows branch from dcaf8cb to b0594a5 Compare May 3, 2020 08:20

add linux only condition

71e27b0

peterjc123 force-pushed the unittest_windows branch 2 times, most recently from 8559457 to 762592a Compare May 3, 2020 09:07

Fix librosa installation

5f561b5

peterjc123 force-pushed the unittest_windows branch from 762592a to 5f561b5 Compare May 3, 2020 09:18

peterjc123 added 6 commits May 3, 2020 17:35

conda-forge channel as a fallback

8c15f66

Revert "conda-forge channel as a fallback"

33bc8b1

This reverts commit 8c15f66.

Try the pytorch way

964f7c6

Use conda-forge

2cc4278

Disable conda-forge

b7648ac

Install future at setup env

e4c7b2f

peterjc123 commented May 3, 2020

View reviewed changes

mthrok and others added 3 commits May 4, 2020 11:03

Move linux unittest CI job tools to dedicated directory

c94c9e6

Restore Linux scripts and move the updated souces to a new subdir

a9b0575

Add back future

e369069

peterjc123 changed the title ~~[WIP] Enable unittest jobs for windows~~ Enable unittest jobs for windows May 4, 2020

peterjc123 marked this pull request as ready for review May 4, 2020 04:15

Remove comments

380de18

vincentqb approved these changes May 4, 2020

View reviewed changes

vincentqb merged commit 4a24ed7 into pytorch:master May 4, 2020

vincentqb mentioned this pull request May 4, 2020

Move linux unit test CI job tools to dedicated directory #605

Closed

peterjc123 deleted the unittest_windows branch May 5, 2020 03:26

mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021

Merge pull request pytorch#604 from pytorch/brianjo-patch-1

60d6ef3

Update index.rst - Adds torchscript to left nav

Conversation

peterjc123 commented May 3, 2020

Uh oh!

peterjc123 May 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vincentqb May 3, 2020

Choose a reason for hiding this comment

Uh oh!

vincentqb commented May 3, 2020

Uh oh!

mthrok commented May 3, 2020

Uh oh!

peterjc123 commented May 3, 2020

Uh oh!

peterjc123 commented May 3, 2020

Uh oh!

mthrok commented May 3, 2020

Uh oh!

mthrok commented May 3, 2020

Uh oh!

mthrok commented May 3, 2020

Uh oh!

peterjc123 commented May 3, 2020

Uh oh!

vincentqb commented May 3, 2020

Uh oh!

codecov bot commented May 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peterjc123 commented May 4, 2020

Uh oh!

vincentqb left a comment

Choose a reason for hiding this comment

Uh oh!

vincentqb commented May 5, 2020

Uh oh!

peterjc123 commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

peterjc123 May 3, 2020 •

edited

Loading

codecov bot commented May 4, 2020 •

edited

Loading