Conversation
vincentqb
suggested changes
Apr 21, 2020
test/README.md
Outdated
| - [`torchaudio.sox_effects`](test/test_sox_effects.py) | ||
| - [`torchaudio.save`, `torchaudio.load`, `torchaudio.info`](test/test_io.py) | ||
|
|
||
| ### Others |
Contributor
There was a problem hiding this comment.
Too generic a title? And the absence of description might be more confusing.
Since this test file is specifically to test that sox interacts correctly with data loader, and thus is unlikely to be updated by users, we could also omit?
Contributor
Author
There was a problem hiding this comment.
I would like to list all the test modules for the completeness, so that when there is a missing module from the list, we can say that it's our oversight.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add README that documents how test directory is organized and (briefly) how to add new tests.
OurThis can be incorporated into the actualCONTRIBUTING.mdcan point this for the direction to add test.CONTRIBUTING.mdcloses #466