Conversation
|
cc @vincentqb Should be ready. However, no tests are running at current. |
|
|
||
|
|
||
| _audio_backend = "sox" | ||
| _audio_backend = "soundfile" if platform.system() == "Windows" else "sox" |
There was a problem hiding this comment.
You recommend making soundfile the default in windows? If that is the case, I'm thinking we may want to make soundfile the default everywhere. Since we are doing the 0.4.0 release now, it may be a good idea to bring this in now so that we have window supported.
Thoughts?
There was a problem hiding this comment.
You recommend making soundfile the default in windows?
I made the change because I was not able to compile the sox backend on Windows. So actually, soundfile is the only available choice for Windows.
If that is the case, I'm thinking we may want to make soundfile the default everywhere.
The major limitation of soundfile is that it cannot read the file with the MP3 format, which is possible in sox.
There was a problem hiding this comment.
Another difficulty I met is that there are no available pysoundfile packages hosted on Anaconda Cloud for Windows. Although the current one is marked as noarch, it is depending on a gcc package which is not available on Windows. So for conda users, the installation script will look a bit weird like this.
conda install -c pytorch torchaudio
pip install soundfile
|
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
Thanks for doing this! Since sox is not an option on windows, we'll fall back to soundfile as you suggest.
2 participants
No description provided.