Merged
Conversation
mthrok
reviewed
Mar 2, 2021
Contributor
mthrok
left a comment
mthrok
left a comment
There was a problem hiding this comment.
Looks good. Let's resolve CI issue and it's good merge.
|
|
||
|
|
||
| _BUILD_SOX = _get_build("BUILD_SOX") | ||
| _BUILD_KALDI = _get_build("BUILD_KALDI") |
Contributor
There was a problem hiding this comment.
Because we currently default to build Kaldi, in case the environment variable is missing, we need to default to true for this.
Please update the _get_build to allow override of default value.
added 2 commits
March 2, 2021 15:33
mthrok
reviewed
Mar 3, 2021
| def _get_build(var): | ||
| if (var == "BUILD_KALDI") and not os.environ.get(var): | ||
| return True | ||
|
|
Contributor
There was a problem hiding this comment.
Although this works for our purpose, let's keep this function generic. How about this?
def _get_build(var, default_val=False):
if val not in os.ennviron:
return default_val
val = os.environ[var]
...
mthrok
reviewed
Mar 3, 2021
| def skipIfNoExtension(test_item): | ||
| if is_module_available('torchaudio._torchaudio'): | ||
| return test_item | ||
| if 'TORCHAUDIO_TEST_FAIL_IF_NO_EXTENSION' in os.environ: |
Contributor
There was a problem hiding this comment.
follow-up (@mthrok): Revive this mechanism with new semantic.
$ grep TORCHAUDIO_TEST_FAIL_IF_NO_EXTENSIO -r .circleci/
.circleci/unittest/linux/scripts/run_test.sh:export TORCHAUDIO_TEST_FAIL_IF_NO_EXTENSION=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support functionality to compile without kaldi, similar to #1338