Fix CI after do_bench refactor in pytorch inductor #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We are relying on some private APIs from inductor and a recent refactor: pytorch/pytorch#125736 broken the do_bench API we rely on for autoquant, maybe we should use our own do_bench or rely on triton's directly? Test Plan: regression tests python test/integration/test_integration.py -k test_autoquant_one_input_29_cuda Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/242
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit adb4b06 with merge base 6af40e5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
andrewor14
approved these changes
May 14, 2024
cpuhrsch
approved these changes
May 14, 2024
lancerts
pushed a commit
to lancerts/ao
that referenced
this pull request
May 17, 2024
Summary: We are relying on some private APIs from inductor and a recent refactor: pytorch/pytorch#125736 broken the do_bench API we rely on for autoquant, maybe we should use our own do_bench or rely on triton's directly? Test Plan: regression tests python test/integration/test_integration.py -k test_autoquant_one_input_29_cuda Reviewers: Subscribers: Tasks: Tags:
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
* chat in browser * remove jinja2 comment seems irrelavant * remove jinja2 comment seems irrelavant * remove debug prints * use torchchat as entry point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are relying on some private APIs from inductor and a recent refactor: pytorch/pytorch#125736 broken the do_bench API we rely on for autoquant, maybe we should use our own do_bench or rely on triton's directly?
Test Plan:
regression tests
python test/integration/test_integration.py -k test_autoquant_one_input_29_cuda
Reviewers:
Subscribers:
Tasks:
Tags: