scatter CI failures #2925
Merged
scatter CI failures #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: lowering
apbose
commented
Jun 17, 2024
Collaborator
Author
There was a problem hiding this comment.
@gs-olive will there be fake tensor issue in this? The torch.compile test seems to be passing here.
Contributor
There was a problem hiding this comment.
Since it is within a decomposition, it should be fine since the torch.ones Tensor itself is never accessed or used
gs-olive
approved these changes
Jun 17, 2024
Contributor
gs-olive
left a comment
gs-olive
left a comment
There was a problem hiding this comment.
Looks good to me - thanks for the quick fix! Just pending 1 CI test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
]