cherry-pick: Python Runtime Windows Builds on TRT 10 (#2764) #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/expand.cpp b/tmp/changes.txt
index 49f1815..0e68768 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/expand.cpp
+++ b/tmp/changes.txt
@@ -44,7 +44,8 @@ bool add_expand(ConversionCtx* ctx, const torch::jit::Node* n, nvinfer1::ITensor
if (size != targetSize) {
if (size != 1) {
TORCHTRT_THROW_ERROR(
- "The expanded size of tensor (" << targetSize << ")" << " must match the existing size (" << size << ")"
+ "The expanded size of tensor (" << targetSize << ")"
+ << " must match the existing size (" << size << ")"
<< " at dimension " << i);
}
}
@@ -131,7 +132,8 @@ bool add_expand_dynamic(
// if size == -1, we can't validate the expansion before setBindingDimensions.
if (!(size == -1 || size == 1)) {
TORCHTRT_THROW_ERROR(
- "The expanded size of tensor (" << targetSize << ")" << " must match the existing size (" << size << ")"
+ "The expanded size of tensor (" << targetSize << ")"
+ << " must match the existing size (" << size << ")"
<< " at dimension " << i);
}
}
diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/evaluators/eval_util.cpp b/tmp/changes.txt
index 2c6567a..9b61390 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/evaluators/eval_util.cpp
+++ b/tmp/changes.txt
@@ -165,7 +165,8 @@ c10::optional<torch::jit::IValue> toIValue(const torch::jit::Value* v) {
void checkListInputType(const c10::TypePtr& elem_type, bool empty_list) {
if (!elem_type->isSubtypeOf(c10::NumberType::get()) && elem_type != c10::BoolType::get()) {
std::stringstream error;
- error << "Input must be of ints, floats, or bools, " << "got " << elem_type->repr_str();
+ error << "Input must be of ints, floats, or bools, "
+ << "got " << elem_type->repr_str();
// special case empty list torch.tensor([])
if (elem_type->isSubtypeOf(c10::TensorType::get())) {
if (empty_list) {
diff --git a/home/runner/work/TensorRT/TensorRT/core/plugins/impl/normalize_plugin.h b/tmp/changes.txt
index 7e564b5..5d51a68 100644
--- a/home/runner/work/TensorRT/TensorRT/core/plugins/impl/normalize_plugin.h
+++ b/tmp/changes.txt
@@ -41,7 +41,7 @@ class NormalizePlugin : public nvinfer1::IPluginV2DynamicExt {
const char* getPluginNamespace() const noexcept override;
- void setPluginNamespace(const char* pluginNamespace) noexcept override {};
+ void setPluginNamespace(const char* pluginNamespace) noexcept override{};
nvinfer1::IPluginV2DynamicExt* clone() const noexcept override;
@@ -101,7 +101,7 @@ class NormalizePluginCreator : public nvinfer1::IPluginCreator {
const char* getPluginNamespace() const noexcept override;
- void setPluginNamespace(const char* libNamespace) noexcept override {};
+ void setPluginNamespace(const char* libNamespace) noexcept override{};
const char* getPluginName() const noexcept override;
diff --git a/home/runner/work/TensorRT/TensorRT/core/plugins/impl/interpolate_plugin.h b/tmp/changes.txt
index 661cee2..ce009af 100644
--- a/home/runner/work/TensorRT/TensorRT/core/plugins/impl/interpolate_plugin.h
+++ b/tmp/changes.txt
@@ -57,7 +57,7 @@ class InterpolatePlugin : public nvinfer1::IPluginV2DynamicExt {
const char* getPluginNamespace() const noexcept override;
- void setPluginNamespace(const char* pluginNamespace) noexcept override {};
+ void setPluginNamespace(const char* pluginNamespace) noexcept override{};
nvinfer1::IPluginV2DynamicExt* clone() const noexcept override;
@@ -117,7 +117,7 @@ class InterpolatePluginCreator : public nvinfer1::IPluginCreator {
const char* getPluginNamespace() const noexcept override;
- void setPluginNamespace(const char* libNamespace) noexcept override {};
+ void setPluginNamespace(const char* libNamespace) noexcept override{};
const char* getPluginName() const noexcept override;
ERROR: Some files do not conform to style guidelines
gs-olive
force-pushed
the
windows_builds_cherry_pick
branch
from
c01fc84 to
bd90a99
Compare
gs-olive
force-pushed
the
windows_builds_cherry_pick
branch
2 times, most recently
from
409795e to
6353d02
Compare
narendasan
reviewed
Apr 26, 2024
gs-olive
force-pushed
the
windows_builds_cherry_pick
branch
from
6e5f83b to
a2d1836
Compare
gs-olive
requested review from
github-actions[bot]
and removed request for
github-actions[bot]
gs-olive
force-pushed
the
windows_builds_cherry_pick
branch
from
a2d1836 to
81d7c74
Compare
gs-olive
force-pushed
the
windows_builds_cherry_pick
branch
from
81d7c74 to
90d0226
Compare
laikhtewari
pushed a commit
that referenced
this pull request
May 24, 2024
Co-authored-by: HolyWu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
main(feat: Python Runtime Windows Builds on TRT 10 #2764)Type of change
Please delete options that are not relevant and/or add your own.
Checklist: