make functions defined in quantize_ops.cuh inline #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It is dangerous to define non-inline function in header file without. This happens to work because only one compilation unit includes quantize_ops.cuh but this breaks (as seen from a follow-up diff) to generate duplicated symbols Differential Revision: D28632972 fbshipit-source-id: cbaf5cda79075135ecc4b6051b4f02acb4430bc6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28632972 |
Contributor
|
This pull request has been merged in dd3abd3. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#612 This reverts commit 5c16f4b. This is not needed anymore after pytorch/pytorch#143423. I think this will also fix the issue with building torchrec CPU https://github.com/pytorch/FBGEMM/actions/runs/12470608879/job/34806045264?pr=3528#step:18:219 ### Testing https://github.com/pytorch/FBGEMM/actions/runs/12470608879 X-link: pytorch#3528 Reviewed By: q10 Differential Revision: D67602736 Pulled By: huydhn fbshipit-source-id: ec5888acacd96295dd6dfe26e5fa87b28810b2bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It is dangerous to define non-inline function in header file without. This happens to work because only one compilation unit includes quantize_ops.cuh but this breaks (as seen from a follow-up diff) to generate duplicated symbols
Differential Revision: D28632972