Do not call scalar_type
#3394
Closed
Do not call scalar_type
#3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
malfet
approved these changes
Nov 19, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65310552 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65310552 |
Contributor
Author
|
Are the failed checks still working properly? Build errors are from |
Summary: X-link: facebookresearch/FBGEMM#482 As all argument already should be scalar types. This is setting up for {D64642080} Reviewed By: q10 Differential Revision: D65310552
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65310552 |
Contributor
|
This pull request has been merged in c036b86. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3394 Pull Request resolved: facebookresearch/FBGEMM#482 As all argument already should be scalar types. This is setting up for {D64642080} Reviewed By: q10, malfet Differential Revision: D65310552 fbshipit-source-id: 4ae5f94d82b76d80ace53f9a511cbbe937e1a8a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/482
As all argument already should be scalar types
Reviewed By: q10
Differential Revision: D65310552