Conversation
lostmsu
left a comment
lostmsu
left a comment
There was a problem hiding this comment.
Mostly minor remarks.
Did it snowball this far when adding 3.10 support?
|
Sorry for bundling all of these reference changes in this PR, I'll move them to a separate one. Only the first three commits are related to Python 3.10 and are sufficient, from what I can see (I'd rather drop AppVeyor support than waiting for them again before merging). |
|
Any progress on Windows and MacOS tests? |
|
Aren't those essentially the same failures that we have been having for ages and that require fixes to reference counts? I don't have a mac to test, but anecdotally on Windows with Python 3.9, I can't reproduce the failures that we are seeing here. |
|
Well, tests for 3.10 only succeeded on Linux. Tests for 3.9 only randomly fail on Linux and MacOS, but even there pass quite often. |
|
I'll have another look. From the logs it looks like there is no published numpy wheel for 3.10 yet, so when installing dependencies it has to be compiled which takes quite a long time and results in the jobs actually being cancelled. |
|
In that case we should increase timeout for 3.10 specifically or across the board until there are numpy wheels. |
- Add Python 3.10 typeoffsets - Replace call to (removed) `PyUnicode_GetMax` by platform detection, as AFAIK only Windows uses 16bit wchar_t
Also increase CI timeout for now as some dependencies have no wheels available, yet, and are thus compiled during CI.
|
As always, I can't reproduce the errors locally :/ |
2 participants
What does this implement/fix? Explain your changes.
Support for Python 3.10
Does this close any currently open issues?
Surprisingly, no one has asked for it yet :)
Any other comments?
This drops the usage of
PyUnicode_GetMaxas it was removed from Python 3.10.Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG