Filter out DeprecationWarning on IPython import in test suite #653
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And unpin pytest again, since the pin in python-triogh-650 was just a temporary fix. Fixes python-triogh-651.
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 99.31% 99.32% +<.01%
==========================================
Files 95 95
Lines 11028 11030 +2
Branches 786 786
==========================================
+ Hits 10953 10955 +2
Misses 56 56
Partials 19 19
Continue to review full report at Codecov.
|
Fuyukai
approved these changes
Sep 10, 2018
Member
|
For posterity: IPython has fixed this upstream and I think prompt-toolkit has also been fixed (but by deleting the file, so it might just have been moved), so we won't need the filters forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And unpin pytest again, since the pin in gh-650 was just a temporary
fix.
Fixes gh-651.