Wrap exception groups less when raising in as_safe_channel#3334
Merged
Zac-HD merged 1 commit intopython-trio:mainfrom Sep 21, 2025
Merged
Wrap exception groups less when raising in as_safe_channel#3334Zac-HD merged 1 commit intopython-trio:mainfrom
as_safe_channel#3334Zac-HD merged 1 commit intopython-trio:mainfrom
Conversation
While this loses a little bit of information on pre-3.11 versions, I think it's worth the readability improvements. I could be convinced that conditionally raising the exception group with the special note would work too, though. This commit also simplifies a test by accounting for cancellation. Fixes python-trio#3332
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3334 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 125 125
Lines 19582 19586 +4
Branches 1341 1342 +1
===============================================
+ Hits 19582 19586 +4
🚀 New features to boost your workflow:
|
Zac-HD
approved these changes
Sep 21, 2025
CoolCat467
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3332