Skip to content

Use PEP 562 instead of _ModuleWithDeprecations #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TeamSpen210 merged 4 commits into from
Mar 27, 2025
Merged

Use PEP 562 instead of _ModuleWithDeprecations #3230

TeamSpen210 merged 4 commits into from
Mar 27, 2025

Conversation

@A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Mar 22, 2025 •
edited
Loading

Presumably fixes #2135 but I haven't checked this and I'm not sure how to test this (as it relies on cloudpickle not pickle).

@codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17373%. Comparing base (b6813ed) to head (6f94687).
Report is 132 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b6813ed) and HEAD (6f94687). Click for more details.

HEAD has 70 uploads less than BASE
Flag BASE (b6813ed) HEAD (6f94687)
macOS 21 14
3.11 14 9
3.10 12 8
Ubuntu 24 16
3.12 15 10
3.14 12 8
3.9 25 16
Cython 8 4
Alpine 3 2
3.13 14 9
Windows 45 30
pypy-3.10 9 6
Additional details and impacted files 
@@                  Coverage Diff                  @@
##                 main       #3230          +/-   ##
=====================================================
- Coverage   100.00000%   56.17373%   -43.82627%     
=====================================================
  Files             124         246         +122     
  Lines           18779       37530       +18751     
  Branches         1269        2538        +1269     
=====================================================
+ Hits            18779       21082        +2303     
- Misses              0       16320       +16320     
- Partials            0         128         +128
Files with missing lines Coverage Δ
src/trio/__init__.py 100.00000% <100.00000%> (ø)
src/trio/_deprecate.py 100.00000% <100.00000%> (ø)
src/trio/_tests/module_with_deprecations.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_deprecate.py 100.00000% <100.00000%> (ø)

... and 126 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TeamSpen210
TeamSpen210 reviewed Mar 22, 2025
View reviewed changes
@TeamSpen210 TeamSpen210 added this pull request to the merge queue Mar 27, 2025
Merged via the queue into python-trio:main with commit c632be5 Mar 27, 2025
42 of 43 checks passed
@A5rocks A5rocks deleted the change-deprecated-attributes branch June 9, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TeamSpen210 TeamSpen210 TeamSpen210 approved these changes

@CoolCat467 CoolCat467 CoolCat467 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't pickle trio as a package

3 participants

@A5rocks @TeamSpen210 @CoolCat467