Codecov Report

Merging #2654 (52d1ddf) into master (93c1d96) will decrease coverage by 2.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2654      +/-   ##
==========================================
- Coverage   97.67%   94.75%   -2.93%     
==========================================
  Files         124      236     +112     
  Lines       16753    32888   +16135     
  Branches        0     4283    +4283     
==========================================
+ Hits        16364    31162   +14798     
- Misses        389     1520    +1131     
- Partials        0      206     +206     

hmmnope, didn't help.

What I'm seeing is if TYPE_CHECKING not ignoring branches: https://app.codecov.io/gh/python-trio/trio/blob/master/trio/_path.py#L190

And in #2629 I tried omitting trio/_tests/check_type_completeness.py which didn't do shit.

Could be because I removed a thing that copies .coveragerc into the empty directory? You might need to --cov-config=../.coveragerc

okay that did fix omit (although not sure if that changes anything in this branch) - but I fail to get the exclude_lines regex to work / the content of if TYPE_CHECKING: ignored when running locally. I tried modifying it, I tried exclude_also instead, but no go. Only thing that seemed to work was adding # pragma: no cover to the lines... 🤔

Oh, it looks like it worked in CI .. I think? trio/_path.py and trio/_channel.py are at 100% at least. The load of negative percentages I think is because we're back to running with branch=True?
Feel free to merge if you think it looks good so I can take a look at the coverage of #2629 properly afterwards.