Skip to content

Conversation

@njsmith
Copy link
Member

@njsmith njsmith commented Aug 17, 2019

Fixes: gh-550, gh-1191

@oremanj
Copy link
Member

oremanj commented Aug 17, 2019

You'll need to hide the async generator test from the 3.5 builds. Otherwise looks good.

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #1192 into master will decrease coverage by <.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.01%     
==========================================
  Files         106      106              
  Lines       12800    12818      +18     
  Branches      983      984       +1     
==========================================
+ Hits        12745    12762      +17     
- Misses         35       36       +1     
  Partials       20       20
Impacted Files Coverage Δ
trio/_core/tests/test_run.py 100% <100%> (ø) ⬆️
trio/_core/_run.py 99.59% <80%> (-0.14%) ⬇️

@njsmith
Copy link
Member Author

njsmith commented Aug 18, 2019

So apparently my first version didn't work at all, because we were replacing coro after creating the Task object, so the Task kept going with the original coroutine... fortunately codecov caught it. I fixed that and made the test more robust, so I think this is good now?

@python-trio python-trio deleted a comment from codecov bot Aug 18, 2019
@wgwz wgwz merged commit 8807eab into python-trio:master Aug 18, 2019
@njsmith
Copy link
Member Author

njsmith commented Aug 18, 2019

@njsmith njsmith deleted the support-c-async-functions branch August 18, 2019 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Cython-based async functions

3 participants