Conversation
instead use _collections_abc for the alias Bug: python-rope#801 Signed-off-by: Nowa Ammerlaan <[email protected]>
The PermissionError is now raised earlier when we initialize the iterdir object instead of when we attempt to get the next() Closes: python-rope#801 Signed-off-by: Nowa Ammerlaan <[email protected]>
|
@lieryan Is it possible to consider merging this? 🙏 We'd really like Rope to support Python 3.13 :) |
lieryan
approved these changes
Jul 12, 2025
Member
|
Thanks for fixing this issue, @Nowa-Ammerlaan. |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
collections/abc.py, update thedeprecated_aliasesvariable for this casePermissionErrorearlier on initialization of theiterdir()instead of just onnext()Fixes #801