Skip to content

add windows and mac CI#481

Merged
lieryan merged 18 commits intopython-rope:masterfrom
bagel897:patch-1
Jun 17, 2022
Merged

add windows and mac CI#481
lieryan merged 18 commits intopython-rope:masterfrom
bagel897:patch-1

Conversation

@bagel897
Copy link
Contributor

@bagel897 bagel897 commented Jun 2, 2022

Description

Rope is supposed to work across other platforms, yet CI doesn't currently cover them causing bugs like #477 to make it into released code.

Issues causing failure

  • macos (>=3.8) and windows fail DOA tests.
  • Windows doesn't report correctly due to different shell syntax
  • Windows fails some autoimport tests

I don't know enough to fix the DOA tests, but will try to fix the autoimport ones after this PR is merged.

@bagel897 bagel897 mentioned this pull request Jun 5, 2022
@bagel897 bagel897 marked this pull request as ready for review June 15, 2022 00:19
@lieryan lieryan merged commit caeaf60 into python-rope:master Jun 17, 2022
@lieryan
Copy link
Member

lieryan commented Jun 17, 2022

As always, great work @bageljrkhanofemus. Thanks for raising this issue and fixing it.

@lieryan lieryan added this to the 1.2.0 milestone Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants