Conversation
6 tasks
Member
|
Instead of checking for not a file, couldn't ? Also, I did find it strange that python-lsp-server has a pytest.exe in its sys.path; adding a folder check in rope might be a hack around what could be a deeper issue in python-lsp-server's tests setup, but nevertheless I agree that it's sensible for rope to just ignore garbage/unusable paths here. |
Member
|
Thank you for fixing this issue. I don't have Windows to test this on, but the fix seems like it should be safe enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On windows, the python sys.path includes random files. I do not have windows and 100% of development is on linux but it failed on pylsp's CI. I filtered out files from the search, but cannot easily test this code. I am also unsure of why files are included in sys.path on windows.
Fixes
autoimport on windows.