fix: Add DottedKey to a super table gives wrong output (#431)#435
Merged
frostming merged 1 commit intopython-poetry:masterfrom Jul 7, 2025
deltamarnix:add-dotted-keys-to-super
Merged
fix: Add DottedKey to a super table gives wrong output (#431)#435frostming merged 1 commit intopython-poetry:masterfrom deltamarnix:add-dotted-keys-to-super
frostming merged 1 commit intopython-poetry:masterfrom
deltamarnix:add-dotted-keys-to-super
Conversation
When a table is already a super table, appending dotted items to it will result in wrong behavior. The header was missing, so the final result was an incorrect representation of the document. Because super_table is already set and can no longer be re-evaluated, I have added a check to the renderer instead, so that it can determine if the header should be rendered. I have not gone through different edge cases, but it seems that all other tests are still passing.
frostming
approved these changes
Jul 7, 2025
Contributor
|
Thank you for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a table is already a super table, appending dotted items to it will result in wrong behavior. The header was missing, so the final result was an incorrect representation of the document.
Because super_table is already set and can no longer be re-evaluated, I have added a check to the renderer instead, so that it can determine if the header should be rendered.
I have not gone through different edge cases, but it seems that all other tests are still passing.