Skip to content

Comments

Multiple code quality improvements#212

Merged
frostming merged 15 commits intopython-poetry:masterfrom
Secrus:multiple-code-quality
Jul 28, 2022
Merged

Multiple code quality improvements#212
frostming merged 15 commits intopython-poetry:masterfrom
Secrus:multiple-code-quality

Conversation

@Secrus
Copy link
Member

@Secrus Secrus commented Jul 18, 2022

  • Added a few flake8 plugins and corrected issues that raised
  • Added pyupgrade (set to 3.6+)
  • Added pycln linter

Secrus added 4 commits July 19, 2022 09:18
- removed `exclude` from `pycln` pre-commit config
- removed adding of futture-annotations import from isort config
- added `TOMLDocument` to `__all__` list in tomlkit/__init__.py
@Secrus Secrus changed the title Multiple code quality improvements [WIP] Multiple code quality improvements Jul 25, 2022
@Secrus Secrus marked this pull request as draft July 25, 2022 13:16
@Secrus Secrus changed the title [WIP] Multiple code quality improvements Multiple code quality improvements Jul 25, 2022
@Secrus Secrus marked this pull request as ready for review July 25, 2022 14:17
@Secrus Secrus requested a review from frostming July 25, 2022 14:18
Copy link
Contributor

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frostming frostming merged commit 0449c53 into python-poetry:master Jul 28, 2022
@Secrus Secrus deleted the multiple-code-quality branch August 11, 2022 21:57
capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
* Add pre-commit config

* First pre-commit swipe (isort, flake8-bugbear, black, pyupgrade)

* Flake8-broken-line and flake8-comprehensions

* Flake8-eradicate, flake8-simplify, pep8-naming

* flake8-use-fstring

* flake8-tidy-imports, flake8-quotes

* flake8-typing-imports, flake8-type-checking

* pycln

* Remove unnecessary comments

* Update versions of plugins

* Code review changes

- removed `exclude` from `pycln` pre-commit config
- removed adding of futture-annotations import from isort config
- added `TOMLDocument` to `__all__` list in tomlkit/__init__.py

* Revert "First pre-commit swipe (isort, flake8-bugbear, black, pyupgrade)"

This reverts commit 60abdac.

* Remove unnecessary option

* Remove unnecessary isort config option

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants