export complete package names (including features)#65
Merged
abn merged 1 commit intopython-poetry:mainfrom May 26, 2022
dimbleby:extras
Merged
export complete package names (including features)#65abn merged 1 commit intopython-poetry:mainfrom dimbleby:extras
abn merged 1 commit intopython-poetry:mainfrom
dimbleby:extras
Conversation
on its own this doesn't achieve anything, further fixes in poetry must follow to make this effective
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
The plan that I outline only works if #64 is also merged, else we fall foul of poetry-plugin-export/src/poetry_plugin_export/exporter.py Lines 118 to 119 in db1db23 |
abn
approved these changes
May 26, 2022
Merged
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have in mind a fix to python-poetry/poetry#5537 such that the packages returned by
get_project_dependency_packages()include any features that ought to be installed.Then this fix will cause those features to be included at export.
(Except for local dependencies, which I suppose would need some different fix. I don't intend to do anything about that in this MR: it's getting a touch complicated and I don't myself care about exporting
requirements.txtfor local dependencies).