Skip to content

Comments

fix --index-url handling for Poetry 1.8 - second try#270

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:fix-index-urls
Mar 19, 2024
Merged

fix --index-url handling for Poetry 1.8 - second try#270
radoering merged 1 commit intopython-poetry:mainfrom
radoering:fix-index-urls

Conversation

@radoering
Copy link
Member

  • if PyPI is disabled the highest prio source get --index-url, others get --extra-index-url
  • if PyPI is enabled we just do not use --index-url, all other source get --extra-index-url
  • put --index-url before --extra-index-url to work around a pip bug

Resolves: #269
Resolves: #149

Copy link

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #269 for me, thanks!

@radoering radoering requested a review from a team March 18, 2024 19:08
- if PyPI is disabled the highest prio source get `--index-url`, others get `--extra-index-url`
- if PyPI is enabled we just do not use `--index-url`, all other source get `--extra-index-url`
- put `--index-url` before `--extra-index-url` to work around a pip bug
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.0% Duplication on New Code

See analysis details on SonarCloud

@radoering radoering merged commit 07f8981 into python-poetry:main Mar 19, 2024
@radoering radoering deleted the fix-index-urls branch August 24, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing --extra-index-url lines in requirements.txt for second primary package source index-url and extra-index-url in wrong order

3 participants