Fix: Include explicit sources in export command#205
Merged
radoering merged 1 commit intopython-poetry:mainfrom May 26, 2023
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
I understand the concern raised by SonarCloud regarding the usage of HTTP. However, in the context of this PR, this alert can be safely ignored. The code snippet in question aligns with existing code found here: |
Member
|
You can ignore SonarCloud. Maintainers just have to review if it's relevant or not (as in this case). |
radoering
approved these changes
May 26, 2023
This was referenced May 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
poetry exportcommand was not exporting the--extra-index-urland--trusted-hostoptions as expected forexplicitsources.Previously, the
Exporterclass was calling therepositoriesproperty from theRepositoryPoolin thepoetrypackage to fetch all repository information. However,repositoriesexcludesexplicitrepositories.To resolve this issue, I have modified the
Exporterclass to use theall_repositoriesproperty instead ofrepositories. Theall_repositoriesproperty includesexplicitrepositories and ensures the--extra-index-urland--trusted-hostoptions are exported correctly.fixes: #204