package: do not default to develop#98
Merged
abn merged 1 commit intopython-poetry:masterfrom Mar 12, 2021
Merged
Conversation
This was referenced Oct 6, 2020
mrcljx
added a commit
to mrcljx/poetry
that referenced
this pull request
Oct 8, 2020
abn
force-pushed
the
fix/package-develop
branch
from
ea6dc50 to
3855247
Compare
Setting develop to `True` by default causes un-expected side-effects and requires downstream consumers to rely on checks like `package.develop and package.source_type == "directory""` to determine if develop mode. This also corresponds to current high-level behaviour of packages being non-develop by default.
abn
force-pushed
the
fix/package-develop
branch
from
3855247 to
e336277
Compare
kasteph
approved these changes
Mar 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting develop to
Trueby default causes un-expected side-effectsand requires downstream consumers to rely on checks like
package.develop and package.source_type == "directory""to determineif develop mode (python-poetry/poetry#3099).
This also corresponds to current high-level behaviour of packages being
non-develop by default.