Skip to content

Comments

markers: simplify union of inverse (or partially inverse) atomic single markers#858

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:simplify-union-atomic-single-markers
Apr 23, 2025
Merged

markers: simplify union of inverse (or partially inverse) atomic single markers#858
radoering merged 1 commit intopython-poetry:mainfrom
radoering:simplify-union-atomic-single-markers

Conversation

@radoering
Copy link
Member

@radoering radoering commented Apr 21, 2025 •
edited by sourcery-ai bot
Loading

  • Added tests for changed code.
  • Updated documentation for changed code.

Without the fix, the union of
sys_platform == "win32" or sys_platform == "linux" and
sys_platform != "win32" and sys_platform != "darwin" is not simplified to
sys_platform != "darwin".

Further, the union of
sys_platform == "win32" or sys_platform == "linux" and
sys_platform != "win32" and sys_platform != "linux"
is not recognized as AnyMarker.

Summary by Sourcery

Improve marker constraint simplification logic for union and intersection operations, focusing on handling inverse and partially inverse atomic markers

New Features:

  • Add support for simplifying unions of inverse and partially inverse atomic markers

Enhancements:

  • Optimize union constraint simplification to handle more complex marker scenarios
  • Improve handling of marker intersections and unions

Tests:

  • Add test cases for inverse and partially inverse atomic markers
  • Expand test coverage for marker constraint simplification

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 21, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request simplifies the union of inverse (or partially inverse) atomic single markers. The changes involve modifications to the union method in UnionConstraint to handle inverse relationships, along with the addition of new test cases to ensure correct behavior.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Simplified the union operation for inverse or partially inverse atomic single markers.
  • Modified the union method in UnionConstraint to handle cases where one constraint is the inverse or partially inverse of another.
  • Added logic to recognize when the union of a constraint and its inverse results in AnyConstraint.
  • Implemented simplification logic to remove redundant constraints when combining unions and multi-constraints.
  • Added new test cases to verify the correct behavior of the union operation with inverse and partially inverse markers.
 tests/constraints/generic/test_constraint.py
tests/version/test_markers.py
src/poetry/core/constraints/generic/union_constraint.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 21, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like some of the tests in test_constraint.py could be simplified further.
  • Consider extracting the marker simplification logic into a separate function for better readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering requested a review from a team April 21, 2025 15:43
@radoering radoering merged commit 1aea290 into python-poetry:main Apr 23, 2025
18 checks passed
This was referenced May 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Secrus Secrus Secrus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radoering @Secrus