Skip to content

Comments

fix created_nested_marker for python wildcard constraints#853

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:fix-create-nested-marker-python-wildcard
Mar 26, 2025
Merged

fix created_nested_marker for python wildcard constraints#853
radoering merged 1 commit intopython-poetry:mainfrom
radoering:fix-create-nested-marker-python-wildcard

Conversation

@radoering
Copy link
Member

@radoering radoering commented Mar 23, 2025 •
edited by sourcery-ai bot
Loading

Resolves: python-poetry/poetry#10290

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Bug Fixes:

  • Fixes an issue where nested markers were not correctly created for Python wildcard constraints.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 23, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request fixes an issue where wildcard constraints were not correctly handled when generating environment markers. The create_nested_marker function was updated to use the stable version representation for comparison, and new test cases were added to ensure the correct behavior for wildcard version constraints.

Sequence diagram for create_nested_marker function

sequenceDiagram
    participant Utils
    participant Version

    Utils->>Version: version.stable
    Version-->>Utils: Returns stable version
    Utils->>Utils: Creates environment marker with stable version
Loading

File-Level Changes

Change Details Files
Adjusted the version normalization within the create_nested_marker function to correctly handle wildcard constraints.
  • Modified the version comparison logic to use the stable version representation when constructing environment markers.
  • Ensured that wildcard constraints are properly converted into version ranges for environment markers.
 src/poetry/core/packages/utils/utils.py
Added test cases to verify the correct generation of nested markers for wildcard version constraints.
  • Introduced new test scenarios covering various wildcard version patterns.
  • Asserted that the generated markers accurately reflect the intended version ranges.
 tests/packages/utils/test_utils.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 23, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It might be clearer to use version.base_version instead of version.stable.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering requested a review from a team March 23, 2025 16:42
@radoering radoering force-pushed the fix-create-nested-marker-python-wildcard branch from b9e36e5 to c4c4591 Compare March 25, 2025 16:28
@radoering radoering force-pushed the fix-create-nested-marker-python-wildcard branch from c4c4591 to 31be139 Compare March 26, 2025 18:44
@radoering radoering enabled auto-merge (squash) March 26, 2025 18:44
@radoering radoering merged commit bb0071a into python-poetry:main Mar 26, 2025
18 checks passed
This was referenced Mar 29, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Secrus Secrus Secrus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Poetry Core: parse_constraint can create unparseable max for SingleMarker

2 participants

@radoering @Secrus