Skip to content

Comments

markers: avoid unnecessary stack depth#848

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:marker-of-branch-swap
Mar 11, 2025
Merged

markers: avoid unnecessary stack depth#848
radoering merged 1 commit intopython-poetry:mainfrom
radoering:marker-of-branch-swap

Conversation

@radoering
Copy link
Member

@radoering radoering commented Mar 8, 2025 •
edited by sourcery-ai bot
Loading

This is a slight performance optimization and preliminary work for improvements to union_simplify and intersect_simplify. The SingleMarker branch finally ends in the multi/union branch via some function calls anyway, so we can shortcut it by checking for multi/union markers first.

Related to: python-poetry/poetry#10249

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Enhancements:

  • Optimize marker intersection and union operations by prioritizing checks for MultiMarker and MarkerUnion instances.

@radoering
markers: avoid unnecessary stack depth
6abcadc 
This is a slight performance optimization and preliminary work for improvements to `union_simplify` and `intersect_simplify`. The `SingleMarker` branch finally ends in the multi/union branch via some function calls anyway, so we can shortcut it by checking for multi/union markers first.
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 8, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request optimizes marker intersection and union operations by prioritizing simplification of MarkerUnion and MultiMarker types, respectively, before handling SingleMarkerLike types. This change reduces stack depth and improves performance. It also lays groundwork for future improvements to union_simplify and intersect_simplify.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Optimize marker intersection by prioritizing MarkerUnion simplification.
  • Moved the MarkerUnion simplification check before the SingleMarkerLike check in the intersection logic.
  • Added a flag to prevent redundant checks when one of the markers is a MarkerUnion.
 src/poetry/core/version/markers.py
Optimize marker union by prioritizing MultiMarker simplification.
  • Moved the MultiMarker simplification check before the SingleMarkerLike check in the union logic.
  • Added a flag to prevent redundant checks when one of the markers is a MultiMarker.
 src/poetry/core/version/markers.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 8, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It might be clearer to move the is_one_union and is_one_multi checks directly into the if conditions to improve readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering requested a review from a team March 8, 2025 06:52
@radoering radoering merged commit 776fb4b into python-poetry:main Mar 11, 2025
18 checks passed
This was referenced Mar 29, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Secrus Secrus Secrus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radoering @Secrus