Merged
Conversation
Without this change the union of `extra == "a" and extra == "c"` and `extra == "a" or extra == "b"` is `extra == "a" and extra == "c" or extra == "a" or extra == "b"`. With the change, it is simplified to `extra == "a" or extra == "b"`.
Reviewer's Guide by SourceryThis pull request simplifies the union of marker constraints, specifically addressing cases where combining an 'or' condition with an 'and' condition can be reduced to a simpler 'or' condition. This optimization avoids unnecessarily complex marker expressions. Sequence diagram for union constraint simplificationsequenceDiagram
participant UC as UnionConstraint
participant MC as MultiConstraint
UC->UC: union(other: MultiConstraint)
alt any(c in other.constraints for c in self._constraints)
UC-->UC: return self
else
UC->UC: new_constraints = [*self._constraints, other]
UC-->UC: return new UnionConstraint(new_constraints)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @radoering - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be helpful to add a comment explaining the logic behind the early return in
union.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Secrus
approved these changes
Mar 5, 2025
This was referenced Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change the union of
extra == "a" and extra == "c"andextra == "a" or extra == "b"isextra == "a" and extra == "c" or extra == "a" or extra == "b". With the change, it is simplified toextra == "a" or extra == "b".Related to: python-poetry/poetry#10195
Similar to: #842
Summary by Sourcery
Tests: