Refactor sources and extras handling on packages and dependencies#78
Merged
Refactor sources and extras handling on packages and dependencies#78
Conversation
sdispater
force-pushed
the
refactor-packages-dependencies
branch
from
863c13a to
69fc718
Compare
abn
requested changes
Sep 4, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Overall I like the direction we are heading in. Some comments.
sdispater
force-pushed
the
refactor-packages-dependencies
branch
from
69fc718 to
c2d37ff
Compare
finswimmer
requested changes
Sep 5, 2020
sdispater
force-pushed
the
refactor-packages-dependencies
branch
2 times, most recently
from
8baa9e1 to
60fd7b0
Compare
2 tasks
sdispater
force-pushed
the
refactor-packages-dependencies
branch
5 times, most recently
from
c670d7f to
0c18d81
Compare
abn
approved these changes
Sep 16, 2020
Member
|
@sdispater LGTM one comment for offline discussion maybe is https://github.com/python-poetry/poetry-core/pull/78/files#r489371619 |
abn
requested changes
Sep 16, 2020
sdispater
force-pushed
the
refactor-packages-dependencies
branch
from
0c18d81 to
72c803c
Compare
abn
approved these changes
Sep 16, 2020
This was referenced Sep 18, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#2545
Resolves: python-poetry/poetry#2494
Resolves: python-poetry/poetry#2300
Resolves: python-poetry/poetry#2080
Resolves: python-poetry/poetry#1609
This is a preliminary work to solve the referenced issues on Poetry's end.
This PR refactors and improves the way packages and dependencies are compared to each other, by taking into account their source and their features/extras.
This the first step of a complete refactor of packages and sources that will be done in the 1.2 release of Poetry.