Add build config settings to core#715
Conversation
|
I think, we are open for this setting. Please also create a downstream (draft) PR that shows the usage of this setting. (You can replace the poetry-core dependency with a git dependency pointing to your branch in a temporary commit that will be dropped before merging.) |
radoering
left a comment
There was a problem hiding this comment.
I suppose, this setting is relevant for all types of dependencies because it's not just relevant for directories but also for sdists?
|
Yes.
…On Mon, Apr 1, 2024, 5:09 AM Randy Döring ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I suppose, this setting is relevant for all types of dependencies because
it's not just relevant for directories but also for sdists?
—
Reply to this email directly, view it on GitHub
<#715 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMUJYRLHL4LPQMM3BMR3Y3EP3BAVCNFSM6AAAAABFLAEW42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZQHE2TCNJSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hello @earonesty |
|
I never finished the other side of it. This PR is complete from what I can
tell
…On Wed, Jun 26, 2024, 12:03 PM Igor Sadchenko ***@***.***> wrote:
Hello @earonesty <https://github.com/earonesty>
Any updates here?
Maybe do you need help with this PR?
—
Reply to this email directly, view it on GitHub
<#715 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMUMFEAIT5N33ZHSVRN3ZJMF6PAVCNFSM6AAAAABFLAEW42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGQZTSMJQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@earonesty apologies for getting to this sooner. Really appreciate your effort in getting this proposed. I have proposed python-poetry/poetry#10129 which will close this out unfortunately. While I can see the value add in having this configurable in the dependency spec, I do not think this is the appropriate solution for this as things stand. By the nature of these config settings, they are not universal in most cases. A configuration that works for a user on linux machine might not work for someone on an osx machine (or vice-versa) etc. This is why python-poetry/poetry#10129 proposes the introduction of a configuration setting instead of an addition to the Yes, there are some cases where it might make sense to have a "default" config for every developer (think corporate environment with uniform developer environments). For these cases, I propose that users simply commit a Please also let me know if there are areas that the proposal falls short on for your original use case. Once again, thank you for your contributions. |




The build() function takes optional config-settings which can be useful for building gpu-specific packages, editable-mode settings for setuptools, or other build-tool specific configurations. If used, should resolve a number of issues. For example: python-poetry/poetry#8909
(Sorry for the million commits, im editing this in a browser.)
See: https://build.pypa.io/en/stable/api.html. Typing matches that.
If there's no objections, will finish adding tests, etc.