Fix editable installs with extension modules#633
Merged
radoering merged 3 commits intopython-poetry:mainfrom Sep 1, 2023
Merged
Fix editable installs with extension modules#633radoering merged 3 commits intopython-poetry:mainfrom
radoering merged 3 commits intopython-poetry:mainfrom
Conversation
robbotorigami
force-pushed
the
fix_editable_installs
branch
2 times, most recently
from
3061c8a to
b406de0
Compare
dimbleby
reviewed
Aug 30, 2023
robbotorigami
force-pushed
the
fix_editable_installs
branch
from
b406de0 to
6b861c6
Compare
dimbleby
reviewed
Aug 30, 2023
robbotorigami
force-pushed
the
fix_editable_installs
branch
from
6b861c6 to
d1d0865
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
radoering
changed the title
This was referenced Oct 30, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#8377
Credit to @matthewwardrop for the fix (#335). I've rebased onto the current main branch and added unit tests for the modified functionality. I've also tested against the projects I was having issues with and confirmed that this resolves the issues I was having.