Skip to content

Comments

Build wheel from from dynamically created package via custom build.py#629

Merged
radoering merged 2 commits intopython-poetry:mainfrom
rragundez:main
Sep 11, 2023
Merged

Build wheel from from dynamically created package via custom build.py#629
radoering merged 2 commits intopython-poetry:mainfrom
rragundez:main

Conversation

@rragundez
Copy link
Contributor

Resolves: python-poetry#8312
python-poetry/poetry#8312

  • Added tests for changed code.
  • Updated documentation for changed code.

@rragundez
Copy link
Contributor Author

Hi @radoering thanks for fixing the error in the CI.

Anything else missing or that I need to add to move this PR forward?

@radoering
Copy link
Member

No, LGTM. It just has to wait for python-poetry/poetry#8369.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering radoering merged commit 8859499 into python-poetry:main Sep 11, 2023
@rragundez
Copy link
Contributor Author

@radoering do you know when will the changes are expected to be release in a new version? I need this functionality to submit a PR in Keras Core.

@radoering
Copy link
Member

We'll probably do a release to officially support Python 3.12. The Python 3.12 release is scheduled for 2023-10-02, so I suppose we'll try to do a release near that date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants