Introduce wheel tag regex#592
Closed
rmarquis wants to merge 6 commits intopython-poetry:mainfrom
rmarquis:fix-wheel-tag-regex
Closed
Introduce wheel tag regex#592rmarquis wants to merge 6 commits intopython-poetry:mainfrom rmarquis:fix-wheel-tag-regex
rmarquis wants to merge 6 commits intopython-poetry:mainfrom
rmarquis:fix-wheel-tag-regex
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#3509
This is a follow-up of PR #227, based on the work of @jrandall rebased on latest stable version, squashed and cleaned up, with the addition of requested changes by @radoering.
As @jrandall is seemingly unresponsive, this is an attempt at getting his work merged in poetry-core. All credits to him.
As suggested in #227, the initial PR is divided in 2 parts:
This is based on PR #591, which would need to be merged first.
I am unfortunately not sure about how to properly test with mocking of the proposed change, so this PR is in draft status at the moment. Any guidance is welcome here.
The first PR should actually fix most use cases, as this second PR is only needed for backward compatibility of older projects. New projects built with poetry should work properly with #591.