performance: fix a performance regression introduced in #402#582
Merged
radoering merged 1 commit intopython-poetry:mainfrom May 12, 2023
Merged
Conversation
radoering
force-pushed
the
pypa-packaging-compliance-performance
branch
from
d15103b to
19492bb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Secrus
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a perfomance regression introduced in #402 by applying
cached_propertyto certain propertiescached_propertyis available since Python 3.8. There is a package namedbackports.cached-property, which makes the decorator available in Python 3.7. However, I don't want to add a new vendored dependency since we will drop Python 3.7 support anyway in the near future. We could introduce a restricted dependency onbackports.cached-propertylike in poetry or just accept the performance regression for Python 3.7. I have chosen the latter but do not have strong feelings about it.In the following table you can see the
cumtimeof relevant calls (in seconds) from profiling different variants for a sample project